Skip to content

[golang] bump to golang 1.23#1564

Closed
stuggi wants to merge 3 commits into
openstack-k8s-operators:mainfrom
stuggi:golang_1.23
Closed

[golang] bump to golang 1.23#1564
stuggi wants to merge 3 commits into
openstack-k8s-operators:mainfrom
stuggi:golang_1.23

Conversation

@stuggi

@stuggi stuggi commented Aug 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • bump in go.mod (base and api)
  • bump go-toolset in Dockerfile
  • bump golang version and custom_image in github jobs ('.github/workflows')
  • Bump the golangci-lint version in the .pre-commit-config.yaml to v2.4.0
  • Bump build_root_image in .ci-operator.yaml to ci-build-root-golang-1.23-sdk-1.31 (if set)

To test on existing env:

  • update golang to 1.23
  • delete current go.work* files
  • init go work files go work init

Depends-On: openstack-k8s-operators/install_yamls#1080

Jira: OSPRH-12935

@openshift-ci openshift-ci Bot requested review from abays and fultonj August 14, 2025 13:51
@openshift-ci

openshift-ci Bot commented Aug 14, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stuggi stuggi removed request for abays and fultonj August 14, 2025 13:52
@stuggi

stuggi commented Aug 14, 2025

Copy link
Copy Markdown
Contributor Author

/test images

@softwarefactory-project-zuul

softwarefactory-project-zuul Bot commented Aug 14, 2025

Copy link
Copy Markdown

This change depends on a change that failed to merge.

Change openstack-k8s-operators/install_yamls#1080 is needed.

@softwarefactory-project-zuul

softwarefactory-project-zuul Bot commented Aug 14, 2025

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/985eecb64b1a4aafab5b47e91ceb0a4c

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 49m 36s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 08m 53s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 27m 26s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 22s
❌ adoption-standalone-to-crc-ceph-provider FAILURE in 1h 36m 05s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 31m 34s

@stuggi

stuggi commented Aug 15, 2025

Copy link
Copy Markdown
Contributor Author

/test images

@stuggi stuggi mentioned this pull request Aug 18, 2025
Closed
stuggi added 3 commits August 18, 2025 09:44
@stuggi
bump to golang 1.23
abbf6ac 
* bump in go.mod (base and api)
* bump go-toolset in Dockerfile
* bump golang version and custom_iamge in github jobs ('.github/workflows')
* Bump the golangci-lint version in the .pre-commit-config.yaml to v2.4.0
* Bump build_root_image in .ci-operator.yaml to ci-build-root-golang-1.23-sdk-1.31

Jira: OSPRH-12935

Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
@stuggi
fix golangci reported issuers
7dccab9 
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
@stuggi
[golang] replace "golang.org/x/exp/slices" with stdlib one
57a1c50 
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
@openshift-ci

openshift-ci Bot commented Aug 18, 2025

Copy link
Copy Markdown
Contributor

@stuggi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 57a1c50 link true /test images
ci/prow/functional 57a1c50 link true /test functional
ci/prow/openstack-operator-build-deploy-kuttl 57a1c50 link true /test openstack-operator-build-deploy-kuttl
ci/prow/precommit-check 57a1c50 link true /test precommit-check
ci/prow/openstack-operator-build-deploy-kuttl-4-18 57a1c50 link true /test openstack-operator-build-deploy-kuttl-4-18

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stuggi stuggi mentioned this pull request Aug 18, 2025
Merged
@stuggi

stuggi commented Aug 18, 2025

Copy link
Copy Markdown
Contributor Author

closing in preference of #1567

@stuggi stuggi closed this Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

approved do-not-merge/hold

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@stuggi